Skip to content

redis: skip resolution for ip address#13916

Closed
taoso wants to merge 1 commit intoenvoyproxy:masterfrom
taoso:master
Closed

redis: skip resolution for ip address#13916
taoso wants to merge 1 commit intoenvoyproxy:masterfrom
taoso:master

Conversation

@taoso
Copy link

@taoso taoso commented Nov 5, 2020

The resolution will fail under macos for ip address.

Signed-off-by: 吕海涛 ihaitao@qq.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

The resolution will fail under macos for ip address.

Signed-off-by: 吕海涛 <ihaitao@qq.com>
@taoso taoso requested a review from mattklein123 as a code owner November 5, 2020 12:46
@mattklein123
Copy link
Member

The resolution will fail under macos for ip address.

This was recently fixed by @junr03. I don't think this PR is needed.

@junr03
Copy link
Member

junr03 commented Nov 5, 2020

Yep, should have been fixed in #13698. @lvht can you verify if your issue is still present in a commit after that PR was merged?

@taoso taoso closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants